Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix no release note on day after no commit #4995

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Jul 16, 2024

Checklist

Required

Purpose of change

fix generation of empty release note on daily release when yesterday had no release (this is because in that case nonexistant tag is passed to fromTag)

Describe the solution

  1. compare with tag of last release, not from the day before.
  2. always create/update releases so release note can be updated when manually ran.

Describe alternatives you've considered

remove usage of YESTERDAY_TAG_NAME completely? head foggy so not sure if it'd work

Testing

Additional context

workaround for daily release not running.
skip number of commits check on manual experimental release.
use last tag instead of last date on fromTag
@scarf005 scarf005 merged commit 7d6d40c into main Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants