feat(balance): revamp of rifle spawns, OA-93 rename and buff #5000
+143
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data
chaosvolt
reviewed
Jul 17, 2024
| @@ -85,7 +85,7 @@ | |||
| { "group": "guns_shotgun_common_display", "x": 16, "y": 10, "chance": 100, "magazine": 100 }, | |||
| { "group": "guns_shotgun_rare_static_display", "x": 16, "y": 11, "chance": 25, "magazine": 100 }, | |||
| { "group": "guns_rifle_common_display", "x": 20, "y": 7, "chance": 25, "magazine": 100 }, | |||
| { "group": "guns_rifle_rare_display", "x": 20, "y": 8, "chance": 25, "magazine": 100 }, | |||
There was a problem hiding this comment.
This and the below chance makes it call for two separate spawns of common rifles, and is inconsistent with the nearby calls to spawn rare guns.
There was a problem hiding this comment.
It is due to the fact, that the rare rifles were illegal. The second rifle is spawning on a different spot
chaosvolt
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
mainso it won't cause conflict when updatingmainbranch later.Optional
Purpose of change
This is a full revamp of rifle spawns.
It was very all over the place. Rare rifles also included military only, obscure was everything and nothing. The German G36 and G6 spawned in the rare group with high chances, the French Famas 1/714 in the obscure group.
The OA-93 was renamed to the OA-98 and buffed, since it was a very bad gun with no updates for its magazines or size.
Describe the solution
Describe alternatives you've considered
Testing
Additional context
A new hunting-rifle spawngroup would be a good idea to differentiate between carbines and hunting stuff. Those hunting things can be spawned in rural houses (probably together with hunting shotguns).
we reached 5000!