Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helsing & tihar #700

Merged
merged 18 commits into from
Aug 17, 2021
Merged

Helsing & tihar #700

merged 18 commits into from
Aug 17, 2021

Conversation

SzQ1
Copy link
Contributor

@SzQ1 SzQ1 commented Jul 22, 2021

Summary

SUMMARY: [Content] "Add Pneumatic bolt driver "id": "helsing" and Pneumatic assault rifle "id": "tihar" "

Purpose of change

Give player alternative between Bows/Crossbows and Guns. I imagine those weapons should be a bit stronger than Bows are and less loud than Guns.

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Requires complete balance changes and recipe adjustments. I will compare them with similar level weapons and give an update.

SzQ1 added 2 commits July 22, 2021 21:30
Adding and adjusting Tihar and Helsing item and recipe entries. Beginning sats balancing.
@Coolthulhu
Copy link
Member

The loudness in this PR is 22 and 18. This isn't huge by any means, but the description says they're "very quiet", which is more like loudness 8 or so. Description change may be better than loudness change, depending on what role you intend them to have.

I'm comparing helsing to crossbows and it looks like:

  • The damage per shot looks very much in favor of xbows, with hand xbow having 2x the damage of helsing against unarmored enemies
  • The damage per time unit before reload favors helsing, except in cases of armored enemies
  • Reload time is huge. From what I can tell, it is per-ammo-item, meaning full reload would take 8 minutes (!!!) at 0 skill and 4800-(str*160), minimum 200, at 10 skill. But you'd have to micro it to only reload one-by-one, because STR_RELOAD is applied once and is a flat reduction.
  • Dispersion is heavily in favor of helsing
  • Range is roughly the same, but helsing can utilize it better because dispersion

Tihar is basically a bullet crossbow with a big magazine and auto mode. It has a tiny bit higher dispersion and much higher noise, but it wins at everything else. No problems here.

As for helsing vs crossbow damage calculation:

  • Assuming 200 moves per shot, full reload time, against unarmored target, all hits normal, after 1600 moves, helsing deals 160 dmg, regular xbow deals 90
  • As above, but after 10000 moves, helsing deals 180 dmg, compound xbow deals 480, regular xbow deals 450
  • Assuming 100 moves per shot, 10% reload time, str 10, "infinite moves", helsing deals 5 dmg/100 moves, compound xbow 29/100 moves, regular xbow 25/100 moves
  • A character with 10 str+hydraulic bionic could get 30 str, lowering reload time to minimum (25 moves). At 10 skill, rifles fire once per 15 moves, so helsing can take 40 moves per shot. Helsing 50/100 (dmg/moves), compound 52/100, regular 47/100

That reload should probably be lowered. Also drop STR_RELOAD, it's badly implemented and I don't see a good way of fixing it.

@SzQ1
Copy link
Contributor Author

SzQ1 commented Jul 25, 2021

Helsing

  • range from 20 to 16
  • reload from 6000 to 2000
  • loudness from 22 to 16
  • weight from 3kg to 4kg
  • valid mod locations decreased a bit
  • description from It is very quiet and a bit deadly. to It is pretty quiet and a quite deadly.
  • "STR_RELOAD" removed

Tihar

  • range from 20 to 16
  • loudness from 18 to 14
  • reload_noise_volume from 10 to 8
  • it uses now Tihar magazine
  • valid mod locations decreased a bit
  • description from It is very quiet and a bit deadly. to It is pretty quiet and a quite pretty..
  • "STR_RELOAD" removed

Tihar magazine

"weight": "180 g",
"volume": "250 ml",
"ammo_type": [ "pebble" ],
"capacity": 24,
"reliability": 6,
"reload_time": 800,
"flags": [ "MAG_COMPACT" ]

Comment

Recipes untouched so far. @Leviathan21 have idea to make tihar to be able to shoot only bearings which i lake and could make. Provided a lot of reasoning on weight and balance which I also have hard time to comprehend.

@SzQ1 SzQ1 marked this pull request as ready for review July 26, 2021 22:02
@SzQ1
Copy link
Contributor Author

SzQ1 commented Jul 26, 2021

I wasn't sure what does the ready for review button do so i pressed it.

@Coolthulhu
Copy link
Member

I wasn't sure what does the ready for review button do so i pressed it.

It changes the PR to be mergeable. You should remove the [WiP] from the title if you think it's ready, I usually skip PRs with [WIP] when doing merge runs.

@SzQ1 SzQ1 changed the title [WIP]Helsing & tihar [Testing]Helsing & tihar Aug 5, 2021
@SzQ1
Copy link
Contributor Author

SzQ1 commented Aug 6, 2021

Decreased Helsing dmg to 35 as it felt too strong. I don't see other issues. Not sure what to do with these failed checks below.

@SzQ1 SzQ1 changed the title [Testing]Helsing & tihar Helsing & tihar Aug 6, 2021
@Coolthulhu Coolthulhu self-assigned this Aug 7, 2021
@Coolthulhu
Copy link
Member

"Tihar" is called "pneumatic assault rifle" by itself, but the magazine calls it Tihar.
You removed burst fire from Tihar, so it's no longer really an assault rifle. I recall the weapon it is based on having burst fire.

Tihar has magazines and reloads fast, meaning the pneumatic part is not "reloaded".
Having it use magazines but take a long time to load a new mag could work well.

Neither of the guns has any recoil. They should have at least some so that you can't just aim once and keep shooting at fully aimed accuracy.

@SzQ1
Copy link
Contributor Author

SzQ1 commented Aug 13, 2021

Adjusted a bit

Reloading single bolt takes 8 seconds and one pebble 4 seconds.
@SzQ1
Copy link
Contributor Author

SzQ1 commented Aug 14, 2021

Recoil and dispersion now work as expected. Reload time of single bolt takes 8 s and single pebble 4 s. It forces player to seek safety spot to reload larger part of the clip. Sense wise it takes longer to reload Helsing because bolts are heavier than pebble(right?) and Helsing is able to deal much more damage in short amount of time, especially with better bolts.

Added hand_pump to the recipes since we have this item. Player can find multiple of those before being able to construct those weapons. As well as multiple books with recipe for hand pump "book_learn": [ [ "textbook_fabrication", 4 ], [ "welding_book", 5 ], [ "manual_mechanics", 4 ] ],. Meanwhile it will justify reload times to the player as some might forget that those are pneumatic.

Added  "Be careful where you reload it, pumping air into the tank takes a few seconds." to the descriptions
To make sure player can craft it before being able to make tihar and helsing that are autolearn.
"symbol": "(",
"color": "light_gray",
"name": { "str": "Pneumatic assault rifle" },
"description": "Often called a Tihar, a multistroke pneumatic rifle handcrafted from scrap. Be careful where you reload it, pumping air into the tank takes a few seconds. It is pretty quiet and a quite pretty.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the "Tihar" part fits. Since the game takes place in USA and the recipe is autolearn, there is no good way for someone to name it this.

Also,

It is pretty quiet and a quite pretty.

?

"symbol": "(",
"color": "dark_gray",
"name": { "str": "Pneumatic bolt driver" },
"description": "Often called a Helsing, an eight-shot, revolving barrel, pneumatic bolt driver handcrafted from scrap. Be careful where you reload it, pumping air into the tank takes a few seconds. It is pretty quiet and a quite deadly.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autolearn recipes are essentially invented by the character, so it would be hard for the entire type to gain a nickname.

It is pretty quiet and a quite deadly.

"Quite deadly", without the "a" in front. Unless you wanted to write "a quite deadly weapon" or something like that.

@Coolthulhu
Copy link
Member

Mechanically it looks good now, it's just the descriptions that need fixing.

@Coolthulhu Coolthulhu merged commit 6cb1224 into cataclysmbnteam:upload Aug 17, 2021
@SzQ1 SzQ1 deleted the Helsing-&-Tihar branch August 17, 2021 15:01
@olanti-p olanti-p mentioned this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants