Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Web Design For Main Website #12

Closed
rtizzy opened this issue Sep 19, 2017 · 6 comments
Closed

Create a Web Design For Main Website #12

rtizzy opened this issue Sep 19, 2017 · 6 comments
Labels
docs PRs releated to docs page help wanted

Comments

@rtizzy
Copy link
Contributor

rtizzy commented Sep 19, 2017

See in title.

We are requesting contributors with web design experience to help us create a proper website for Cataclysm: Bright Nights.
@rtizzy rtizzy added help wanted docs PRs releated to docs page labels Sep 19, 2017
@mount2010
Copy link
Contributor

mount2010 commented Sep 24, 2017 •
edited

Can manage basic Express + web stack. Probably won't be able to do this alone, and am completely unable to help with PHP.

@rtizzy
Copy link
Contributor Author

rtizzy commented Sep 25, 2017

@mount2010 I think we've found a solution with a theme. Will likely use Hugo + After-Dark for now. Had an issue upstream that was just answered that should let me get most of it up :)

Do you know basic javascript and the like? It's mostly just javascript, css, html, and markdown.

@mount2010
Copy link
Contributor

I can do all of that. Send me a DM on Discord - Mount2010#9649

@rtizzy
Copy link
Contributor Author

rtizzy commented Oct 4, 2017

@mount2010 Will contact you now

@rtizzy
Copy link
Contributor Author

rtizzy commented Nov 23, 2017

@mount2010

Howdy I attempted reaching out via Discord but was unable to do so.

Is there perhaps a better way to get ahold of you? If you'd like we can schedule a short meeting. I'm currently on Italian time and will be for the next 3 months.

Let me know how I can help get you started.

Thanks again for offering to help.

@mount2010
Copy link
Contributor

@rtizzy Hey. Sorry for the late reply - are you sure you are unable to reach me via Discord? Please tell me your Discord username and discriminator.

@Trokinos Trokinos mentioned this issue Oct 30, 2020
Closed
Coolthulhu pushed a commit that referenced this issue Oct 31, 2020
@BevapDin @olanti-p
Fix crash caused by accessing item of empty list.
d85c9cc 
The function `are_requirements_nearby` accesses `player::backlog::front()`, which causes UB when the `backlog` list is empty.

This is usually checked by the caller, but there is at least one way to reach this function without that check:

```
#2  0x000000000083dfaa in string_id<activity_type>::operator== (rhs=..., this=0xdf1b460) at src/player_activity.h:93
#3  are_requirements_nearby (loot_spots=std::vector of length 21, capacity 32 = {...}, needed_things=..., p=..., activity_to_restore=..., in_loot_zones=true, src_loc=...)
    at src/activity_item_handling.cpp:1113
#4  0x0000000000843a46 in generic_multi_activity_check_requirement (p=..., act_id=..., act_info=..., src=..., src_loc=...,
    src_set=std::unordered_set with 1 element = {...}, check_only=false) at src/activity_item_handling.cpp:2676
#5  0x0000000000852813 in generic_multi_activity_handler (act=..., p=..., check_only=check_only@entry=false) at src/activity_item_handling.cpp:2885
#6  0x0000000000800896 in activity_handlers::multiple_butcher_do_turn (act=<optimized out>, p=<optimized out>) at src/activity_handlers.cpp:3822
#7  0x000000000082b248 in std::_Function_handler<void (player_activity*, player*), void (*)(player_activity*, player*)>::_M_invoke(std::_Any_data const&, player_activity*&&, player*&&) (__functor=..., __args#0=<optimized out>, __args#1=<optimized out>) at /usr/include/c++/8/bits/std_function.h:88
#8  0x00000000008630e3 in std::function<void (player_activity*, player*)>::operator()(player_activity*, player*) const (this=<optimized out>, __args#0=<optimized out>,
    __args#0@entry=0xdf1b330, __args#1=<optimized out>, __args#1@entry=0xdf1ae50) at /usr/include/c++/8/bits/std_function.h:260
#9  0x0000000000860306 in activity_type::call_do_turn (this=0x2c3c930, act=act@entry=0xdf1b330, p=p@entry=0xdf1ae50) at src/activity_type.cpp:118
#10 0x00000000014a968b in player_activity::do_turn (this=this@entry=0xdf1b330, p=...) at src/player_activity.cpp:237
#11 0x00000000013092a4 in npc::do_player_activity (this=this@entry=0xdf1ae50) at src/npcmove.cpp:3299
#12 0x0000000001322a07 in npc::execute_action (this=this@entry=0xdf1ae50, action=<optimized out>, action@entry=npc_player_activity) at src/npcmove.cpp:1237
#13 0x000000000132690a in npc::move (this=this@entry=0xdf1ae50) at src/npcmove.cpp:907
```

This adds a simple check within the function.
@Trokinos Trokinos mentioned this issue Nov 3, 2020
Closed
@scarf005 scarf005 mentioned this issue Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs PRs releated to docs page help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rtizzy @Coolthulhu @mount2010