Fix "_hexdump buffer size too small (114)" which has been spoiling hexdumps #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the side effect of the function is that the buffer gets logged it's hard to test without more refactoring. This sufficed for now.
…xdumps [26/06 23:35:00.478 AD4]: _hexdump buffer size too small (114) Message repeated 6 times The problem was that the allocated length for the buffer was based solely on the length of the input string, not taking into account that a single character of input can require a whole line of hexdump output if it spills over to a new line.
catalinii
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this:
The problem was that the allocated length for the buffer was based solely on the length of the input string, not taking into account that a single character of input can require a whole line of hexdump output if it spills over to a new line.