Separate resource definitions by data source #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1386 +/- ##
==========================================
+ Coverage 83.17% 83.70% +0.53%
==========================================
Files 61 64 +3
Lines 6762 6896 +134
==========================================
+ Hits 5624 5772 +148
+ Misses 1138 1124 -14
Continue to review full report at Codecov.
|
zaneselvans
added
eia861
Split the EIA resource definitions out by form to make it easier to keep track of them. Started incrementally adding EIA-861 tables to the metadata definitions, but not pulling them into the main RESOURCE_METADATA construction yet since they don't work. Also: the EIA 861 data uses multiple different sets of codes to identify the utility "entity type" and they aren't all being recoded right now, so the use of a strict categorical on that column ends up yielding a NA column. Temporarily reverted to StringDtype() to avoid this issue
zaneselvans
changed the title
zaneselvans
added
eia860
katie-lamb
reviewed
Jan 7, 2022
katie-lamb
approved these changes
Jan 7, 2022
This was referenced Mar 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the table-level metadata integrated into
devnow will help @katie-lamb close #1253To that end this PR does:
eia,eia860,eia861andeia923resource modules (they're getting looong).entity_typefield as it is so variable across different data sources and types. See Confirm EIA entity_type designation #669 and Reconcileentity_types_eia/entity_type/ ownership category discrepancies in eia860 & eia861 #1392.