-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dbf xbrl mapping #2088
Dbf xbrl mapping #2088
Conversation
Corrected an incorrect mapping of the billed vs. unbilled electricity revenue tables. Also changed the `mixed-line-ending` pre-commit hook to always enforce Unix style LF endings, rather than Windows CRLF endings, since switching back and forth when someone edits a CSV in Excel causes whole-file diffs when only a few lines have actually changed, and that's not helpful.
For more information, see https://pre-commit.ci
…dl into dbf-xbrl-mapping
Codecov ReportBase: 85.1% // Head: 85.1% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## dev #2088 +/- ##
=====================================
Coverage 85.1% 85.1%
=====================================
Files 72 72
Lines 8202 8202
=====================================
Hits 6981 6981
Misses 1221 1221
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks mostly good. this is a future suggestion, but I think for this kind of pr it would have been helpful to have a lil list of the things you did and why bc there are a few disparate things going on in here. but generally...
- lots of csv's touched bc of the gitattributes/pre-commit changes
- more table descriptions in our ferc db data dictionaries
- renaming
xbrl_column_stem
toxbrl_factoid
- renaming some of the
row_types
in the dbf to xbrl map. - anything else?
I have a few calrifying questions but generally this looks just fine to me.
@cmgosnell I added a description to the PR. Sorry I left that out. This is a mishmash. |
What this PR does
dbf_to_xbrl_tables.csv
that associates old DBF tables with new XBRL tables, so we know which of them are related to each other. This will supplant the table names dictionary we have inpudl.extract.ferc1
right now, and is necessary because there are one-to-many and many-to-one relationships between these tables.plant_in_service_ferc1
table, since it has been replaced by the new DBF + XBRL alignment process & mapping.PR Checklist
Before requesting a review of your pull request, please make sure you've done the
following:
dev
(or the appropriate upstream branch) intoyour branch and resolved any merge conflicts. You may need to do this several
times over the course of a PR as
dev
changes frequently.Running Tests with Tox
for details on how to run the full test suite locally if you need to debug a
particular failure.
descriptive enough for developers and users to understand your code.
data validation tests
pass locally on a fresh DB.
unit tests.
will catch unexpected data issues.
release notes
to reflect your changes. Make sure to reference the PR and any related issues.
questions you'd like reviewers to answer, known issues, solutions you're
unsatisfied with, or other things that deserve special attention from the
reviewer.