Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform f1 othr reg liab #2215

Merged
merged 10 commits into from
Jan 19, 2023
Merged

Transform f1 othr reg liab #2215

merged 10 commits into from
Jan 19, 2023

Conversation

zschira
Copy link
Member

@zschira zschira commented Jan 18, 2023

Overview

This PR implements transformations for the f1_othr_reg_liab table. This table contains a starting_balance, ending_balance, deltas, and a description and list of account numbers. The description and accounts are very freeform, making it difficult to apply a nice structure to this table. Outside of the unstructured nature of this table, it is very straightforward. All I have done is renaming, unstacking starting/ending balances, and dropping invalid rows.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cmgosnell cmgosnell changed the base branch from main to dev January 18, 2023 22:38
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one request to rename a column but everything else looks grand (at least grand enough given the messiness of the underlying data!)

src/pudl/metadata/fields.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 85.6% // Head: 85.7% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (951cbf7) compared to base (950e74f).
Patch coverage: 100.0% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2215   +/-   ##
=====================================
  Coverage   85.6%   85.7%           
=====================================
  Files         73      73           
  Lines       8969    8973    +4     
=====================================
+ Hits        7686    7690    +4     
  Misses      1283    1283           
Impacted Files Coverage Δ
src/pudl/extract/ferc1.py 86.0% <ø> (ø)
src/pudl/metadata/fields.py 100.0% <ø> (ø)
src/pudl/metadata/resources/ferc1.py 100.0% <ø> (ø)
src/pudl/transform/params/ferc1.py 100.0% <ø> (ø)
src/pudl/transform/ferc1.py 95.9% <100.0%> (+<0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zschira zschira merged commit 011f1d7 into dev Jan 19, 2023
@zschira zschira deleted the transform_f1_othr_reg_liab branch January 19, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants