-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform f1 othr reg liab #2215
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one request to rename a column but everything else looks grand (at least grand enough given the messiness of the underlying data!)
Codecov ReportBase: 85.6% // Head: 85.7% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #2215 +/- ##
=====================================
Coverage 85.6% 85.7%
=====================================
Files 73 73
Lines 8969 8973 +4
=====================================
+ Hits 7686 7690 +4
Misses 1283 1283
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Overview
This PR implements transformations for the
f1_othr_reg_liab
table. This table contains astarting_balance
,ending_balance
, deltas, and a description and list of account numbers. The description and accounts are very freeform, making it difficult to apply a nice structure to this table. Outside of the unstructured nature of this table, it is very straightforward. All I have done is renaming, unstacking starting/ending balances, and dropping invalid rows.PR Checklist
dev
).