Remove tables from settings #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zschira
commented
Feb 7, 2023
| "epacems": {"tables"}, | ||
| } | ||
| ) | ||
| ).datasets.dict() |
There was a problem hiding this comment.
Get rid of those nasty excludes!
| @@ -484,7 +484,7 @@ def define_sqlite_db( | |||
| Returns: | |||
| None: the effects of the function are stored inside sqlite_meta | |||
| """ | |||
| for table in ferc1_to_sqlite_settings.tables: | |||
| for table in DBF_TABLES_FILENAMES.keys(): | |||
bendnorman
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Love a PR that deletes code!
We'll have to remember to remove the tables attribute from the FERC 714 settings once it's integrated into the dagster DAG #2266. I could see us eventually removing most of the code in settings.py in favor or using dagster config types for validating years and partitions and using the DAG to specify dataset dependencies.
|
Same with eia861, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR removes tables from the settings models/yaml files, as discussed in #2272.
As @bendnorman mentioned in the PR linked above, it looks like we could use dagster's multi-asset subsetting to allow us to select subsets of tables, but I'm not sure if it's worth the time/energy. Open to other's thoughts on this though. Perhaps it's something we could leave to the future if we have time.
PR Checklist
dev)