Remove code deprecated by dagster #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
zschira
commented
Feb 28, 2023
| @@ -3942,34 +3860,3 @@ def plants_steam_ferc1( | |||
| transformed_fuel=fuel_ferc1, | |||
| ) | |||
| return convert_cols_dtypes(df, data_source="ferc1") | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
There was a problem hiding this comment.
The issue mentioned converting this to use dagster, but I propose we just move this and encourage using the dagster ui to iterate on transformers
There was a problem hiding this comment.
Or the materialize_asset script we made!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dagster-asset-etl #2341 +/- ##
===================================================
Coverage ? 86.1%
===================================================
Files ? 79
Lines ? 9435
Branches ? 0
===================================================
Hits ? 8132
Misses ? 1303
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jdangerx
approved these changes
Mar 1, 2023
| @@ -3942,34 +3860,3 @@ def plants_steam_ferc1( | |||
| transformed_fuel=fuel_ferc1, | |||
| ) | |||
| return convert_cols_dtypes(df, data_source="ferc1") | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
There was a problem hiding this comment.
Or the materialize_asset script we made!
bendnorman
approved these changes
Mar 1, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes code no longer used after the dagster update. Specifically removes
loadmodule, and deprecated code from Ferc 1 transform.#1873 mentions updating docs, but I'm not sure what all @bendnorman has been working, so I didn't want to duplicate any docs updates.