Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s3 bucket urls to use https #2351

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

bendnorman
Copy link
Member

PR Overview

My browser gives me privacy errors when I try to download our s3 data from the link the readme because they use HTTP. I updated the URLs to use the https versions.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b75db5f) 86.1% compared to head (7d6b1e0) 86.1%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2351   +/-   ##
=====================================
  Coverage   86.1%   86.1%           
=====================================
  Files         74      74           
  Lines       9312    9312           
=====================================
  Hits        8021    8021           
  Misses      1291    1291           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bendnorman bendnorman merged commit 73eb0ba into main Mar 2, 2023
@bendnorman bendnorman deleted the update-s3-bucket-urls branch March 2, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants