-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev
into dagster-asset-etl
once again
#2353
Conversation
…y key validation checks
…n validation tests
Add spot fix function/class
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dagster-asset-etl #2353 +/- ##
====================================================
+ Coverage 0 85.9% +85.9%
====================================================
Files 0 79 +79
Lines 0 9638 +9638
====================================================
+ Hits 0 8284 +8284
- Misses 0 1354 +1354
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Whoops, need to delete load.py. That's ruining our patch coverage too. |
Add boiler-associated attributes from EIA 860 6.2 EnvrEquip tables to ETL
a78600e
to
15b3196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing to note: my unit tests fail on the foreign key error still. When I removed pudl.sqlite
they passed, but I think it's just because there's now no data in the pudl.sqlite
...
dev
into dagster-asset-etl
once again
The CI is failing because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments that @bendnorman made about the new post-harvesting boilers_eia860
table and the clean_boilers_eia860
asset (that doesn't get written into the DB) sound right to me.
Updates the requirements on [gcsfs](https://github.com/fsspec/gcsfs) to permit the latest version. - [Release notes](https://github.com/fsspec/gcsfs/releases) - [Commits](https://github.com/fsspec/gcsfs/commits) --- updated-dependencies: - dependency-name: gcsfs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [dask](https://github.com/dask/dask) to permit the latest version. - [Release notes](https://github.com/dask/dask/releases) - [Changelog](https://github.com/dask/dask/blob/main/docs/release-procedure.md) - [Commits](dask/dask@2021.08.0...2023.3.0) --- updated-dependencies: - dependency-name: dask dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…/gcsfs-gte-2021.7-and-lt-2023.3.1 Update gcsfs requirement from <2023.1.1,>=2021.7 to >=2021.7,<2023.3.1
…/dask-gte-2021.8-and-lt-2023.3.1 Update dask requirement from <2023.2.2,>=2021.8 to >=2021.8,<2023.3.1
Updates the requirements on [fsspec](https://github.com/fsspec/filesystem_spec) to permit the latest version. - [Release notes](https://github.com/fsspec/filesystem_spec/releases) - [Commits](fsspec/filesystem_spec@2021.07.0...2023.3.0) --- updated-dependencies: - dependency-name: fsspec dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…/fsspec-gte-2021.7-and-lt-2023.3.1 Update fsspec requirement from <2023.1.1,>=2021.7 to >=2021.7,<2023.3.1
I branched
daz/dagster-asset-etl-dev
off ofdagster-asset-etl
, mergeddev
, and fixed the one merge conflict that was there. Hope CI passes!