Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nightly build message a little cleaner. #2363

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

jdangerx
Copy link
Member

@jdangerx jdangerx commented Mar 6, 2023

I forgot to do this before merging the nightly build stuff. But this is the easiest way for us to "make PRs into main from dev when nightly builds pass." Anything more than this requires pushing GH access into the ETL VM, etc.

@jdangerx jdangerx requested review from a team and zaneselvans and removed request for a team March 6, 2023 22:03
@jdangerx jdangerx self-assigned this Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8d9501c) 85.9% compared to head (93282f8) 85.9%.

Additional details and impacted files
@@                Coverage Diff                @@
##           dagster-asset-etl   #2363   +/-   ##
=================================================
  Coverage               85.9%   85.9%           
=================================================
  Files                     79      79           
  Lines                   9477    9477           
=================================================
  Hits                    8149    8149           
  Misses                  1328    1328           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdangerx jdangerx merged commit 747ce6e into dagster-asset-etl Mar 6, 2023
@jdangerx jdangerx deleted the daz/fix-nightly-build-message branch March 22, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants