Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder PK of boilers_eia860 to group data like other tables #2375

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Mar 9, 2023

PR Overview

By default the data is ordered by primary key in the DB, and the current ordering means that all boilers with the same boiler ID are grouped together, rather than all boilers within a given plant being grouped together, as is the case with generator ID. I think it's more likely that folks would like to see all the boilers that are part of a given plant, than all plants that happen to have a boiler with ID "A1". Check out boilers_eia860 on our Datasette to see what it looks like now.

PR Checklist

@zaneselvans zaneselvans added the eia860 Anything having to do with EIA Form 860 label Mar 9, 2023
@zaneselvans zaneselvans changed the base branch from main to dev March 9, 2023 17:34
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c7568f7) 86.1% compared to head (33455ad) 86.1%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2375   +/-   ##
=====================================
  Coverage   86.1%   86.1%           
=====================================
  Files         74      74           
  Lines       9376    9376           
=====================================
  Hits        8082    8082           
  Misses      1294    1294           
Impacted Files Coverage Δ
src/pudl/metadata/resources/eia860.py 100.0% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eia860 Anything having to do with EIA Form 860 inframundo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants