Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename check_pudl_fks to pudl_check_fks to align w/ other CLI names #2416

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

zaneselvans
Copy link
Member

PR Overview

Renamed check_pudl_fks to pudl_check_fks to follow the naming we've tried to have on our other CLI scripts (as suggested by @karldw waaaay back in #460). We still don't do this on the commands with long names, but it's easy to do here.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@zaneselvans zaneselvans added the cli Scripts and other command line interfaces to PUDL. label Mar 18, 2023
@zaneselvans zaneselvans added this to the 2023Q1 milestone Mar 18, 2023
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c97e7f3) 86.1% compared to head (bd171b2) 86.1%.

Additional details and impacted files
@@                Coverage Diff                @@
##           dagster-asset-etl   #2416   +/-   ##
=================================================
  Coverage               86.1%   86.1%           
=================================================
  Files                     81      81           
  Lines                   9552    9552           
=================================================
  Hits                    8233    8233           
  Misses                  1319    1319           
Impacted Files Coverage Δ
src/pudl/etl/check_foreign_keys.py 68.1% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@bendnorman bendnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great suggestion. Thanks for changing!

@zaneselvans zaneselvans merged commit 7c26798 into dagster-asset-etl Mar 20, 2023
@zaneselvans zaneselvans deleted the rename-check-fks branch March 20, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Scripts and other command line interfaces to PUDL.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants