Simplify EPA CAMD EIA X-walk output to just read from DB. #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneselvans
added
glue
bendnorman
approved these changes
Mar 22, 2023
Comment on lines
-14
to
-20
| def epacamd_eia(pudl_engine: sa.engine.Engine) -> pd.DataFrame: | ||
| """Pull the EPACAMD-EIA Crosswalk table.""" | ||
| pt = pudl.output.pudltabl.get_table_meta(pudl_engine) | ||
| crosswalk_tbl = pt["epacamd_eia"] | ||
| crosswalk_select = sa.sql.select(crosswalk_tbl) | ||
| crosswalk_df = pd.read_sql(crosswalk_select, pudl_engine) | ||
| return crosswalk_df |
There was a problem hiding this comment.
I'm surprised the original function didn't apply any type conversions. I wonder if passing the table through apply_pudl_dtypes will break downstream analyses.
There was a problem hiding this comment.
Well, we'll know shortly!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dagster-eia861 #2440 +/- ##
===============================================
Coverage 86.4% 86.5%
===============================================
Files 81 81
Lines 9794 9443 -351
===============================================
- Hits 8468 8169 -299
+ Misses 1326 1274 -52
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
A minor simplification of access for the
epacamd_eiatable, since all we do is read it straight from the DB.PR Checklist
dev).