Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Make a PR" link in nightly build success message #2449

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

jdangerx
Copy link
Member

This should make our nightly build slack posts not look silly anymore.

We should merge this as a post-dagster-merge fix to dev I think. Not worth the extra hour of waiting for CI before the dagster merge.

@jdangerx jdangerx self-assigned this Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (82d9775) 86.4% compared to head (73084a2) 86.4%.

Additional details and impacted files
@@                Coverage Diff                @@
##           dagster-asset-etl   #2449   +/-   ##
=================================================
  Coverage               86.4%   86.4%           
=================================================
  Files                     81      81           
  Lines                   9588    9588           
=================================================
  Hits                    8286    8286           
  Misses                  1302    1302           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdangerx jdangerx changed the title Use double quotes to print env var values. Fix "Make a PR" link in nightly build success message Mar 24, 2023
Base automatically changed from dagster-asset-etl to dev March 24, 2023 21:46
@jdangerx jdangerx merged commit b4005a1 into dev Mar 24, 2023
@jdangerx jdangerx deleted the daz/fix-github-ref-interpolation branch March 24, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants