Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use 2021 version of the epacamd_eia crosswalk #2566

Merged
merged 1 commit into from
May 8, 2023

Conversation

zschira
Copy link
Member

@zschira zschira commented May 5, 2023

Use 2021 version of crosswalk

@zschira zschira requested a review from aesharpe May 5, 2023 16:59
Copy link
Member

@aesharpe aesharpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! Do we know that it won't break anything? Also the crosswalk doesn't currently have a year column, I wonder if this is something we want to add?

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (8541226) 86.9% compared to head (4018e3c) 87.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2566   +/-   ##
=====================================
  Coverage   86.9%   87.0%           
=====================================
  Files         84      84           
  Lines       9604    9604           
=====================================
+ Hits        8352    8357    +5     
+ Misses      1252    1247    -5     
Impacted Files Coverage Δ
src/pudl/workspace/datastore.py 75.7% <ø> (+1.8%) ⬆️
src/pudl/etl/glue_assets.py 98.0% <100.0%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aesharpe aesharpe merged commit 55e0885 into dev May 8, 2023
10 checks passed
@aesharpe aesharpe deleted the update_crosswalk branch May 8, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants