Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job names in docs #2641

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jun 7, 2023

PR Overview

Running through the docs for the first time, and noticed that these names were slightly wrong; this is what they look like for me:
Screenshot 2023-06-07 at 21 03 21

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@e-belfer
Copy link
Member

e-belfer commented Jun 7, 2023

Great catch, thanks for the suggestion!

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a1a7ef7) 86.9% compared to head (e2f29aa) 86.9%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2641   +/-   ##
=====================================
  Coverage   86.9%   86.9%           
=====================================
  Files         84      84           
  Lines       9720    9720           
=====================================
  Hits        8447    8447           
  Misses      1273    1273           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zaneselvans zaneselvans merged commit 1c6986c into catalyst-cooperative:dev Jun 7, 2023
10 checks passed
@dstansby dstansby deleted the patch-1 branch June 8, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants