Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot fix ferc exploder #2647

Merged
merged 20 commits into from Jun 21, 2023
Merged

Spot fix ferc exploder #2647

merged 20 commits into from Jun 21, 2023

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    574ec9e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Add a transform main function with spot fixes for certain negative en…

    …ding_balance values for the utility_plant_summary_ferc1 table
    aesharpe committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    c9a681a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    390530c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Configuration menu
    Copy the full SHA
    fad70cd View commit details
    Browse the repository at this point in the history
  2. Switch accum_provision_DAD rows in utility_plant_summary table

    Previously we mapped FERC row 14, Accum Prov for Depr, Amort, & Depl, to the XBRL row accumulated_provision_for_depreciation_amortization_and_depletion_of_plant_utility and FERC row 33, Total Accum Prov (equals 14) (22,26,30,31,32), to a unique row accumulated_provision_for_depreciation_amortization_and_depletion_of_plant_utility_detail (note the '_detail' suffix). The former (sans '_detail') maps to an XBRL calculated value while the latter does not. Technically, row 33 should be the calculated value as it notes all the rows that should sum up to it).
    
    This commit maps row 33 to accumulated_provision_for_depreciation_amortization_and_depletion_of_plant_utility and row 14 to accumulated_provision_for_depreciation_amortization_and_depletion_of_plant_utility_reported. I added the '_reported' suffix instead of the '_detail' suffix because it's more informative.This commit also replaces all the spot-fix rows that reference these values with the correct value name.
    
    This commit also adds one more value to the spot fixer for utility_plant_summary_ferc1
    aesharpe committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ad5a3b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Add spot fix to plant_in_service table that flips certain negative va…

    …lues for electric_plant_sold values where the overall electric_plant_in_service calculation is wrong
    aesharpe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2706266 View commit details
    Browse the repository at this point in the history
  2. Apply reconcile_table_calculations to a copy of the dataframe in the …

    …transform_main function for the plant_in_service table (rather than to the dataframe itself) so we can use the calculations to find the index values for the rows to change in the original dataframe without running the calculations on it (and adding new rows for calculations fixes etc.) This change makes the reconcile_table_calculations function work properly in the transform_end function! Previously it was not calculating the right values after some of the spot fixes.
    aesharpe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    fc2e510 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e01b49a View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Respond to PR comments:

    dquote>
    dquote> Simplify the plant_in_service function so that it just flips all electric_plant_sold values to positive values.
    dquote>
    dquote> Update the accomodations for the fast test so that they only happen in one place (years are trunkated from the final list of spot_fix_pks instead of each of the individual lists before the are concatinated).
    aesharpe committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8c5650b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6773520 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85b8d21 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    9c18306 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3083254 View commit details
    Browse the repository at this point in the history
  3. Add some docs changes to reflect new code and update assertion error …

    …to reflect the fact that now there should only be negative values swapped to positive values
    aesharpe committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    6e8c6cf View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Configuration menu
    Copy the full SHA
    cde26b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Configuration menu
    Copy the full SHA
    1a939bc View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Configuration menu
    Copy the full SHA
    0fd7544 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3c1e22 View commit details
    Browse the repository at this point in the history
  3. Add release notes

    aesharpe committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    d4b15b8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8daa787 View commit details
    Browse the repository at this point in the history