-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pudl@catalyst.coop from docs #2670
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev #2670 +/- ##
=====================================
Coverage 87.1% 87.1%
=====================================
Files 86 86
Lines 10021 10021
=====================================
Hits 8736 8736
Misses 1285 1285 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. Makes sense to leave the email in in the other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the docs build and found a mention of pudl@catalyst.coop that wasn't mentioned in the comments:
The Data Access page still references pudl.catalyst.coop:
if you have suggestions or questions please open a GitHub issue or email us at pudl@catalyst.coop.
* For private communication about the project or to hire us to provide customized data | ||
* To hire us to provide customized data | ||
extraction and analysis, you can email the maintainers: | ||
`pudl@catalyst.coop <mailto:pudl@catalyst.coop>`__ | ||
`hello@catalyst.coop <mailto:hello@catalyst.coop>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Contact Us" section on the docs index page says something similar but uses the pudl@catalyst.coop email:
For private communication about the project or to hire us to provide customized data extraction and analysis, you can email the maintainers: pudl@catalyst.coop
We should pick either hello@catalyst or pudl@catalyst and keep it the same for both.
Hey @aesharpe! I rebuilt the docs locally and viewed the docs built by the RTD CI, and I couldn't find the errors you mentioned. Sometimes I need to force reload the docs built by the RTD CI to see the new changes. |
Hmmm I wonder if I ran the docs build on the wrong branch or something. It also looks fine to me. In which case, smash merge! |
PR Overview
#2665 removed references to pudl@catalyst.coop from datasette. This PR removes pudl@catalyst.coop from a couple of other public-facing pages to discourage folks from emailing pudl@catalyst.coop and instead asking questions on GitHub discussions.
Places
pudl@catalyst.coop
was not removed:pyproject.toml
andsrc/pudl/__init__.py
: I think PyPi gets the email contact information from at least one of these files.CODE_OF_CONDUCT.md
: If folks need to report inappropriate behavior it should not be public!src/pudl/metadata/constants.py
,src/pudl/metadata/sources.py
: I think the zenodo archives pull contact information from these files.PR Checklist
dev
).