Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add electric_plant_depreciation_functional_ferc1 into the calc checking process #2687

Merged
merged 5 commits into from Jun 22, 2023

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Jun 21, 2023

Tiny PR to add the electric_plant_depreciation_functional_ferc1 into the calculation checks pre-explosion for #2016. Addresses issue #2684.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@e-belfer e-belfer requested a review from cmgosnell June 21, 2023 19:28
@e-belfer e-belfer self-assigned this Jun 21, 2023
@e-belfer e-belfer linked an issue Jun 21, 2023 that may be closed by this pull request
1 task
Copy link
Member

@cmgosnell cmgosnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't believe this is so (relatively) straightforward

src/pudl/transform/params/ferc1.py Outdated Show resolved Hide resolved
Comment on lines +1966 to +1967
# We use this name for the calculation but it gets renamed in
# `process_xbrl_metadata` to total.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm yeah i think this is needed bc i never implemented a rename process for raw_xbrl_factoid_to_pudl_name for the unstack_balances_to_report_year_instant_xbrl transform.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.1 ⚠️

Comparison is base (0e6edf0) 88.4% compared to head (2470574) 88.4%.

Additional details and impacted files
@@           Coverage Diff           @@
##             dev   #2687     +/-   ##
=======================================
- Coverage   88.4%   88.4%   -0.1%     
=======================================
  Files         87      87             
  Lines      10139   10139             
=======================================
- Hits        8971    8969      -2     
- Misses      1168    1170      +2     
Impacted Files Coverage Δ
src/pudl/transform/ferc1.py 96.8% <ø> (ø)
src/pudl/transform/params/ferc1.py 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@e-belfer e-belfer merged commit fa46f5b into dev Jun 22, 2023
9 of 10 checks passed
@e-belfer e-belfer deleted the electric_depreciation_functional branch June 22, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants