New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electric_plant_depreciation_functional_ferc1
into the calc checking process
#2687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't believe this is so (relatively) straightforward
# We use this name for the calculation but it gets renamed in | ||
# `process_xbrl_metadata` to total. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm yeah i think this is needed bc i never implemented a rename process for raw_xbrl_factoid_to_pudl_name
for the unstack_balances_to_report_year_instant_xbrl
transform.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #2687 +/- ##
=======================================
- Coverage 88.4% 88.4% -0.1%
=======================================
Files 87 87
Lines 10139 10139
=======================================
- Hits 8971 8969 -2
- Misses 1168 1170 +2
☔ View full report in Codecov by Sentry. |
Tiny PR to add the
electric_plant_depreciation_functional_ferc1
into the calculation checks pre-explosion for #2016. Addresses issue #2684.PR Checklist
dev
).