Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apparent typos in FERC 1 rename params. #2691

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

zaneselvans
Copy link
Member

PR Overview

A few of the column renames in the utility_plant_summary_ferc1 table appear to have had some cut-and-paste or search-and-replace typos in them, resulting in missing underscores between components of the name. Unless there's some unusual reason we need not to have those underscores?

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@zaneselvans zaneselvans added bug Things that are just plain broken. ferc1 Anything having to do with FERC Form 1 xbrl Related to the FERC XBRL transition dbf Data coming from FERC's old Visual FoxPro DBF database file format. labels Jun 23, 2023
@cmgosnell
Copy link
Member

did you check the xbrl table's metadata to be sure that this isn't a type that we inherited?

@zaneselvans
Copy link
Member Author

It does appear to be a pre-existing typo. I hate it.

@cmgosnell
Copy link
Member

yeah it looks like the tests are failing bc this name exists in the table itself. i think you want to rename this properly your going to have to pull these names out of the dict comprehension in the instant_xbrl parameter and add them to the end in a way that fixes the typo and adds the suffix we want.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (da42cb9) 88.4% compared to head (c2cd943) 88.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2691   +/-   ##
=====================================
  Coverage   88.4%   88.4%           
=====================================
  Files         87      87           
  Lines      10139   10139           
=====================================
  Hits        8971    8971           
  Misses      1168    1168           
Impacted Files Coverage Δ
src/pudl/transform/params/ferc1.py 100.0% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zaneselvans
Copy link
Member Author

@cmgosnell should we go ahead and merge this?

@cmgosnell cmgosnell merged commit 46ed47d into dev Jun 28, 2023
10 checks passed
@cmgosnell cmgosnell deleted the fix-ferc1-rename-param-typos branch June 28, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that are just plain broken. dbf Data coming from FERC's old Visual FoxPro DBF database file format. ferc1 Anything having to do with FERC Form 1 xbrl Related to the FERC XBRL transition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants