add straggler dbf-only factoids into ferc1 table metadata #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneselvans
requested changes
Jul 7, 2023
src/pudl/transform/ferc1.py
Outdated
| "ferc_account": [pd.NA], | ||
| "xbrl_factoid_original": ["accumulated_deferred_income_taxes"], | ||
| "intra_table_calc_flag": [True], | ||
| "row_type_xbrl": ["report_value"], |
There was a problem hiding this comment.
This should be "reported_value" in all of the fixes.
src/pudl/transform/ferc1.py
Outdated
Comment on lines
2369
to
2376
| { | ||
| "calc_component_to_replace": {}, | ||
| "calc_component_new": { | ||
| "name": "unappropriated_undistributed_subsidiary_earnings_previous_year", | ||
| "weight": 1.0, | ||
| "source_tables": ["retained_earnings_ferc1"], | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Are these changes to the calculation fixes related to the dbf-only facts?
There was a problem hiding this comment.
ah no this is just one of the many instances of factoids that weren't actually in the data.
src/pudl/transform/ferc1.py
Outdated
| "intra_table_calc_flag": True, | ||
| "row_type_xbrl": "report_value", | ||
| } | ||
| for dbf_onl_fact in ["special_funds_all", "nuclear_fuel"] |
There was a problem hiding this comment.
The computer doesn't care but did you mean for this to be dbf_only_fact?
zaneselvans
approved these changes
Jul 7, 2023
zaneselvans
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
I started with just adding the dfb-only metadata fields into each table's metada doing it in a bespokey way. will probably parameterize this adding of these guys.
PR Checklist
dev).