Link electric OpEx to income statement table #2723
Conversation
src/pudl/transform/ferc1.py
Outdated
| # This is already an in-table calculated field so we need to handle | ||
| # it differently. | ||
| # "utility_operating_expenses": [ |
There was a problem hiding this comment.
I wasn't sure what to make of these commented out calculations, which seem related to but different from the ones I've added, and didn't understand the comment above them.
There was a problem hiding this comment.
hm this is an ella question idk
There was a problem hiding this comment.
I think we're aiming for the same goal here, and you just caught a few sub-fields I had missed, so I defer to your calculation. Is there a reason that sales_expense which is also listed as an operation expense isn't included as a component?
The issue of having one calculation for the electric dimension and one calculation for the non-electric dimensions still remains (and is what the original comment above this section is trying to point out, if unclearly).
There was a problem hiding this comment.
Following our conversation, scratch the second point - this calculation is correct and mine points to the wrong factoid, fixing the calculation part of this issue.
zaneselvans
added
ferc1
| "amortization_and_depletion_of_utility_plant": [ | ||
| { | ||
| "calc_component_to_replace": {}, | ||
| "calc_component_new": { | ||
| "name": "amortization_limited_term_electric_plant", | ||
| "weight": 1.0, | ||
| "source_tables": [ | ||
| "depreciation_amortization_summary_ferc1" | ||
| ], | ||
| "utility_type": "electric", | ||
| "subdimension": "electric", | ||
| }, | ||
| }, | ||
| { | ||
| "calc_component_to_replace": {}, | ||
| "calc_component_new": { | ||
| "name": "amortization_other_electric_plant", | ||
| "weight": 1.0, | ||
| "source_tables": [ | ||
| "depreciation_amortization_summary_ferc1" | ||
| ], | ||
| "utility_type": "electric", | ||
| "subdimension": "electric", | ||
| }, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
These calculations link line 8 of the income statement form to the last two data columns in the depreciation amortization summary table.
These factoids appear in the original data table and the original metadata for this table, but they appear to be missing from the exploded metadeta and exploded data, which seems weird to me. This table is part of the income statement hierarchy that we're working with.
I copied the use of utility type and subdimension here, but I don't understand what subdimension means.
There was a problem hiding this comment.
@e-belfer does this new calculation seem reasonable?
@cmgosnell do you know why some of these facts might show up in the original data/metadata but not make it through to the exploded versions?
There was a problem hiding this comment.
I think this seems reasonable - here the "subdimension" refers to the plant_function column which is initially total in the raw data but we've replaced with electric, while utility_type still refers to electric as well.
PR Overview
PR Checklist
dev).