Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete it all!!!! lol remove the no-longer needed duplication removals #2724

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

cmgosnell
Copy link
Member

PR Overview

i kept in the deletion of the totals in the subdimensions bc i don't forsee us integrating that into the calc forest. its still commented out for now

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

i kept in the deletion of the totals in the subdimensions bc i don't
forsee us integrating that into the calc forest. its stil commented out
for now
@cmgosnell cmgosnell marked this pull request as ready for review July 14, 2023 18:13
Base automatically changed from xbrl-calculation-tree to explode_ferc1 July 14, 2023 20:08
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.3 🎉

Comparison is base (a45b5cf) 88.1% compared to head (483eee1) 88.4%.

Additional details and impacted files
@@               Coverage Diff               @@
##           explode_ferc1   #2724     +/-   ##
===============================================
+ Coverage           88.1%   88.4%   +0.3%     
===============================================
  Files                 88      88             
  Lines              10686   10641     -45     
===============================================
- Hits                9416    9410      -6     
+ Misses              1270    1231     -39     
Impacted Files Coverage Δ
src/pudl/output/ferc1.py 89.3% <ø> (+5.9%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmgosnell cmgosnell merged commit 4fcc3dd into explode_ferc1 Jul 14, 2023
10 checks passed
@cmgosnell cmgosnell deleted the explode_delete branch July 14, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant