Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract FERC Form 60 DBF data to SQLite #2734

Merged
merged 3 commits into from Jul 20, 2023
Merged

Extract FERC Form 60 DBF data to SQLite #2734

merged 3 commits into from Jul 20, 2023

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Jul 18, 2023

Addresses the last bit of issue #1984, by adding FERC Form 60 DBF data as a .sqlite database following the template for FERC Form 6.

To do:

  • update release notes
  • poke at the guts and make sure things look as expected

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@e-belfer e-belfer changed the base branch from main to dev July 18, 2023 19:15
@e-belfer e-belfer self-assigned this Jul 18, 2023
@e-belfer e-belfer added new-data Requests for integration of new data. dbf Data coming from FERC's old Visual FoxPro DBF database file format. ferc60 labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (ffffedc) 88.4% compared to head (2031b5c) 88.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2734   +/-   ##
=====================================
  Coverage   88.4%   88.4%           
=====================================
  Files         88      89    +1     
  Lines      10176   10199   +23     
=====================================
+ Hits        9001    9024   +23     
  Misses      1175    1175           
Impacted Files Coverage Δ
src/pudl/extract/ferc6.py 100.0% <ø> (ø)
src/pudl/metadata/sources.py 100.0% <ø> (ø)
src/pudl/extract/ferc.py 100.0% <100.0%> (ø)
src/pudl/extract/ferc60.py 100.0% <100.0%> (ø)
src/pudl/settings.py 98.8% <100.0%> (+<0.1%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zaneselvans
Copy link
Member

Looks like it extracted the FERC Form 60 DBF data!

@e-belfer
Copy link
Member Author

f60_admin and f60_s0_checks and f60_s0_row_changes are empty, as expected. Everything else looks good.

@e-belfer e-belfer marked this pull request as ready for review July 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbf Data coming from FERC's old Visual FoxPro DBF database file format. ferc60 new-data Requests for integration of new data.
Projects
Archived in project
2 participants