-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to helpers and update DBF extraction tests #2841
Conversation
This is just me being a little bit OCD. * Added type hints to all remaining functions in pudl.helpers that didn't have them. * Added schema compatability checks for FERC 6 and 60 DBF derived SQLite DBs. * Removed a no lonter used `pudl.hemlers.merge_dicts()` function. * Use a context manager when dropping tables in `pudl.helpers.drop_tables()`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other changes suggested while you're at it, and one non-blocking question. Otherwise looks good, presuming the code runs as expected.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #2841 +/- ##
=======================================
- Coverage 88.5% 88.5% -0.1%
=======================================
Files 90 90
Lines 10139 10139
=======================================
- Hits 8983 8982 -1
- Misses 1156 1157 +1
☔ View full report in Codecov by Sentry. |
PR Overview
This is just me being a little bit OCD.
pudl.helpers.drop_tables()
PR Checklist
dev
).