Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename allocate net generation fuel assets #2865

Merged
merged 4 commits into from Sep 21, 2023

Conversation

bendnorman
Copy link
Member

@bendnorman bendnorman commented Sep 18, 2023

PR Overview

Apply new naming convention to the assets in the allocate_gen_fuel asset group.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (8b468db) 88.5% compared to head (efb2bbd) 88.5%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           rename-core-assets   #2865   +/-   ##
==================================================
  Coverage                88.5%   88.5%           
==================================================
  Files                      90      90           
  Lines                   10139   10139           
==================================================
  Hits                     8982    8982           
  Misses                   1157    1157           
Files Changed Coverage Δ
src/pudl/analysis/allocate_gen_fuel.py 91.3% <ø> (ø)
src/pudl/analysis/mcoe.py 97.4% <ø> (ø)
src/pudl/metadata/resources/allocate_gen_fuel.py 100.0% <ø> (ø)
src/pudl/metadata/resources/eia.py 100.0% <ø> (ø)
src/pudl/metadata/resources/eia860.py 100.0% <ø> (ø)
src/pudl/output/pudltabl.py 90.1% <100.0%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from rename-eia-output-assets to rename-core-assets September 19, 2023 13:17
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor migration history revision needed (see comment), otherwise looks good and runs as expected.


# revision identifiers, used by Alembic.
revision = '62f1f694f6af'
down_revision = 'c73882df0765'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this to 'b3eb1a80721c' made this branch work as expected for me.

@e-belfer e-belfer self-requested a review September 21, 2023 12:52
@e-belfer e-belfer merged commit 09a876d into rename-core-assets Sep 21, 2023
11 checks passed
@e-belfer e-belfer deleted the rename-allocate-gen-fuel-assets branch September 21, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants