Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename heat_rate_mmbtu_mwh -> unit_heat_rate_mmbtu_per_mwh... again #3029

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Rename heat_rate_mmbtu_mwh -> unit_heat_rate_mmbtu_per_mwh... again #3029

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d61005d
Rename heat_rate_mmbtu_mwh -> heat_rate_mmbtu_mwh_by_unit
bendnorman Oct 4, 2023
53e2f2d
Rename heat rate mmbtu mwh to follow existing naming convention
bendnorman Oct 4, 2023
d8c01da
Rename heat_rate_mmbtu_mwh_eia/ferc1 columns to unit_heat_rate_mmbtu_…
bendnorman Nov 8, 2023
afaa449
Remove unused ppe_cols_to_grab variable
bendnorman Nov 8, 2023
0f90efa
Resolve migration issues with unit heat rate column
bendnorman Nov 15, 2023
f82b56e
Merge branch 'rename-core-assets' into rename-heat-rate-mmbtu-mwh-column
bendnorman Nov 15, 2023
7ef9c70
Recreate heat rate migration revision
bendnorman Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
113 changes: 0 additions & 113 deletions migrations/versions/1ceb9897fd34_add_data_maturity_to_eia923m_tables.py
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with there being several migration versions in here changing? Including older ones? Is this search-and-replace gone wild? It seems like the older migrations might actually need to refer to the older column name.

Alternatively, should we wipe all the migrations periodically to keep too many layers from building up? Since I don't think we actually intend for it to be possible to migrate between all database versions.

This file was deleted.

4 changes: 2 additions & 2 deletions migrations/versions/1fef7b82e48b_wipe_schema_and_ferc1_name_transition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21309,7 +21309,7 @@ def upgrade() -> None:
comment="Total annual heat content of fuel consumed by a plant part record in the plant parts list.",
),
sa.Column(
"heat_rate_mmbtu_mwh_eia",
"unit_heat_rate_mmbtu_per_mwh_eia",
sa.Float(),
nullable=True,
comment="Fuel content per unit of electricity generated. Coming from MCOE calculation.",
Expand Down Expand Up @@ -21802,7 +21802,7 @@ def upgrade() -> None:
comment="Simplified fuel type code used in PUDL",
),
sa.Column(
"heat_rate_mmbtu_mwh_ferc1",
"unit_heat_rate_mmbtu_per_mwh_ferc1",
sa.Float(),
nullable=True,
comment="Fuel content per unit of electricity generated. Calculated from FERC reported fuel consumption and net generation.",
Expand Down
35 changes: 0 additions & 35 deletions migrations/versions/3313ca078f4e_demand_hourly_pa_ferc714_report_date_.py
View file
Open in desktop

This file was deleted.