-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the 860m doi #3189
update the 860m doi #3189
Conversation
it seems to all just work which is tres fun but makes sense after looking at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll do the final validation in the CEMS branch.
The change to allow lists in the partitions has broken the docs build script, which reads those partitions to generate the dataset docs and. |
Already on it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation build script isn't expecting to find lists in the partitions, and so is failing when it attempts to build the data source specific docs pages using the Jinja templates. It needs to be updated to accommodate the new metadata structure associated with the newly bundled raw archives.
Overview
Closes #3186.
What problem does this address?
We had to make a new zenodo archive with eia860m a years worth of monthly files zipped together into one resource because file upload limits. So this pr
What did you change?
basically nothing except the DOI. bc @e-belfer added a little logic into the datastore to work with partitions that are lists of partitions. And the excel extractor/the datastore combined already knows how to grab a file out of a zipped file bc of course it does bc so many of our one partition resources have many files. The main place where this is happening is
load_excel_file
.We could remove the first
try
inload_excel_file
because the old eia860m archive being individual files was actually the edge case.Testing
How did you make sure this worked? How can a reviewer verify this?
I ran the fast etl locally. But first I thought I was going to have to muck with the excel extractor so I setup a little notebook testing situation and the simplest setup gave me the eia860m outputs:
To-do list
make pytest-integration-full
passes locally