Tiny fix to make FERC to EIA tests xfail

[katie-lamb]

Overview

Addresses 3 of the 4 test/integration/ferc1_eia_train_test.py::test_validate_override_fixes tests that should XFAIL but don't as mentioned in #3251 . If we don't care about this patch to make those 3/4 tests XFAIL and just want to address the larger problem in a larger PR, then no need to merge this.

What problem does this address?

The following tests should XFAIL but don't because of a small issue with how the parameters are set in the test_validate_override_fixes test.

test/integration/ferc1_eia_train_test.py::test_validate_override_fixes[verified4-report_year4-record_id_eia_override_14-record_id_ferc14-utility_id_pudl_ferc14]
test/integration/ferc1_eia_train_test.py::test_validate_override_fixes[verified5-report_year5-record_id_eia_override_15-record_id_ferc15-utility_id_pudl_ferc15]
test/integration/ferc1_eia_train_test.py::test_validate_override_fixes[verified6-report_year6-record_id_eia_override_16-record_id_ferc16-utility_id_pudl_ferc16]

Based on a scan of the history with this test, I don't think these parameters have ever been correctly set, and these tests have never XFAILed, but I've never touched this test before so I'm not entirely sure.

What did you change?

Since it was a really simple change, I just updated those parameters. But that's really just a patch for the larger issue in this test, which I've moved into #3256 .

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

Edit tasklist title

Beta Give feedback Tasklist To-do list, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure full ETL runs & `make pytest-integration-full` passes locally

   Make sure full ETL runs & make pytest-integration-full passes locally
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. For major data coverage & analysis changes, [run data validation tests](https://catalystcoop-pudl.readthedocs.io/en/latest/dev/testing.html#data-validation)

   For major data coverage & analysis changes, run data validation tests
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. If updating analyses or data processing functions: make sure to update or write data validation tests

   If updating analyses or data processing functions: make sure to update or write data validation tests
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Update the [release notes](../docs/release_notes.rst): reference the PR and related issues.

   Update the release notes: reference the PR and related issues.
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Review the PR yourself and call out any questions or issues you have

   Review the PR yourself and call out any questions or issues you have
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to To-do list

[zaneselvans]

It seems like it's more correct for the tests marked xfail to fail, and if it's just that these parameters were set incorrectly, that seems like a good change. We can refactor the tests in an actual sprint plan.