Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3243 PHMSA transmission part J #3266

Merged
merged 4 commits into from Jan 23, 2024
Merged

3243 PHMSA transmission part J #3266

merged 4 commits into from Jan 23, 2024

Conversation

jdangerx
Copy link
Member

Overview

Closes #3243.

  • add yearly_miles_of_pipe_by_decade to file_map, page_map, page_part_map, skiprows, skipfooter
  • add raw_phmsagas__yearly_miles_of_pipe_by_decade asset to ETL
  • add column map file

Testing

How did you make sure this worked? How can a reviewer verify this?

I ran the ETL, then ran:

from dagster import AssetKey
from pudl.etl import def
asset = defs.load_asset_value(AssetKey("raw_phmsagas__yearly_miles_of_pipe_by_decade"))

And looked at some of the data:

image

The spike in gathering miles in 2022 appears to be due to "Onshore Type C" pipes finally getting reported starting in 2022:

image

Not sure if there's any specific tests I should write about the raw data.

To-do list

Edit tasklist title
Beta Give feedback Tasklist To-do list, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure full ETL runs & make pytest-integration-full passes locally
    Options
  2. For major data coverage & analysis changes, run data validation tests
    Options
  3. If updating analyses or data processing functions: make sure to update or write data validation tests
    Options
  4. Update the release notes: reference the PR and related issues.
    Options
  5. Review the PR yourself and call out any questions or issues you have
    Options

@jdangerx jdangerx linked an issue Jan 19, 2024 that may be closed by this pull request
@e-belfer e-belfer added new-data Requests for integration of new data. phmsa Data from the Pipeline and Hazardous Material Safety Administration labels Jan 19, 2024
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using onshore_type_a rather than onshore_a, so we should pick one to be consistent (there will definitely be one last clean up PR, if we just want to make note of it in an issue I'm ok with that too). Otherwise all looks good here.

@jdangerx
Copy link
Member Author

I'll make it onshore_type_a, it matches the PDF more closely!

@jdangerx jdangerx force-pushed the 3243-phmsa-tx-j branch 2 times, most recently from 54df7a7 to 486335d Compare January 22, 2024 20:30
@jdangerx jdangerx marked this pull request as ready for review January 22, 2024 20:31
@jdangerx jdangerx enabled auto-merge (squash) January 22, 2024 21:41
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb739ed) 92.7% compared to head (5df0503) 92.7%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3266     +/-   ##
=======================================
- Coverage   92.7%   92.7%   -0.0%     
=======================================
  Files        144     144             
  Lines      13091   13091             
=======================================
- Hits       12135   12134      -1     
- Misses       956     957      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdangerx jdangerx enabled auto-merge (squash) January 23, 2024 14:49
@jdangerx jdangerx merged commit ab0092a into main Jan 23, 2024
13 checks passed
@jdangerx jdangerx deleted the 3243-phmsa-tx-j branch January 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-data Requests for integration of new data. phmsa Data from the Pipeline and Hazardous Material Safety Administration
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Map columns for transmission J
2 participants