Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map PHMSA Natural Gas Transmission Part R columns #3269

Merged
merged 5 commits into from Jan 22, 2024

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Jan 19, 2024

Overview

Closes #3268

What problem does this address?
Extracts Part R in a raw format for PHMSA transmission data into one table, raw_phmsagas__yearly_gas_transmission_miles_by_pressure_test_range_and_internal_inspection. This table includes data from 2012-2022 only.

What did you change?
Mapped columns for the relevant table, and updated the remaining CSVs in src/pudl/package_data/phmsagas.

Testing

How did you make sure this worked? How can a reviewer verify this?

Generate the asset in dagster.

To-do list

Edit tasklist title
Beta Give feedback Tasklist To-do list, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure full ETL runs & make pytest-integration-full passes locally
    Options
  2. Update the release notes: reference the PR and related issues.
    Options
  3. Review the PR yourself and call out any questions or issues you have
    Options

@e-belfer e-belfer self-assigned this Jan 19, 2024
@e-belfer e-belfer added new-data Requests for integration of new data. phmsa Data from the Pipeline and Hazardous Material Safety Administration labels Jan 19, 2024
@@ -56,6 +56,7 @@ def process_final_page(self, df, page):
"raw_phmsagas__yearly_miles_of_gathering_pipe_by_nps",
"raw_phmsagas__yearly_miles_of_transmission_pipe_by_nps",
"raw_phmsagas__yearly_inspections_and_assessments",
"raw_phmsagas__yearly_gas_transmission_miles_by_pressure_test_range_and_internal_inspection",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh this is a long name but also it does make sense

@e-belfer e-belfer changed the base branch from main to phmsa-transmission-n-o January 22, 2024 21:30
@e-belfer e-belfer marked this pull request as ready for review January 22, 2024 21:32
@e-belfer e-belfer merged commit 327f865 into phmsa-transmission-n-o Jan 22, 2024
9 of 11 checks passed
@e-belfer e-belfer deleted the phmsa-transmission-r branch January 22, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-data Requests for integration of new data. phmsa Data from the Pipeline and Hazardous Material Safety Administration
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Map columns for PHMSA transmission part R
2 participants