Nightly build quality of life improvements #3287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Doesn't close any issues - but these are some tiny quality of life improvements that make debugging nightly builds easier:
pudl-etl.log
now has a prefix to indicate date, hash, and short-ref! no more of this:What did you change?
Testing
How did you make sure this worked? How can a reviewer verify this?
I added an early
return 1
to all the time-consuming functions & alsoecho "some message" > $LOGFILE
. Then I ran the build via workflow, saw the various messages in the logfile, and saw that the logfile was uploaded with a nice, unambiguous name.I couldn't verify that the skip logic is working, I think we're good to wait on that until we see a skip occur in the wild.
To-do list