Output Parquet files as well as SQLite in PUDL ETL #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use pyarrow.parquet for writing/reading, add BaseSettings to configure input/output behaviors. By default, let both modes be disabled but allow overrides via PUDL_WRITE_TO_PARQUET and PUDL_READ_FROM_PARQUET env variables.
For more information, see https://pre-commit.ci
Conversion to pyarrow table was necessary before writing to parquet.
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
For more information, see https://pre-commit.ci
This makes more sense as the io manager should be format independent.
This encapsulation makes it much nicer than passing around fixtures.
This reverts commit a400446.
|
@bendnorman I think we're just waiting to see if your comments were all addressed. |
bendnorman
approved these changes
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zaneselvans
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR is a branch off of #3232 . Most of the changes come from that branch/pr with a few additions which attempt to answer unresolved questions from that ongoing PR. Specific changes here include: refactoring where the
check_foreign_keyslogic lives, reverting the use ofunittestfor consistency (I don't feel too strongly either way, but consistency is nice), and removing the check for extra columns fromenforce_schemawhich was causing CI to fail.