Skip batch job if build was skipped as a whole. #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdangerx
requested review from
a team and
zaneselvans
and removed request for
a team
zaneselvans
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What problem does this address?
The 2024-02-11 and 2024-02-12 builds were skipped, but we didn't get a Slack notification because the GHA itself failed.
What did you change?
We had forgotten to skip the "kick off a batch job" step when the build was skipped, so it was trying to do that, failing, and then not sending any notification.
I added the skip condition + force the slack notif to always run.
Testing
How did you make sure this worked? How can a reviewer verify this?
We'll see if it works the next time we have a skip!
To-do list