Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIA AEO table description units to be consistent with columns. #3626

Merged
merged 1 commit into from
May 9, 2024

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented May 8, 2024

Overview

Fix a tiny units inconsistency I saw when reviewing the EIA AEO table documentation.

To-do list

Edit tasklist title
Beta Give feedback Tasklist To-do list, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Ensure docs build in CI.
    Options
  2. Review the PR yourself and call out any questions or issues you have
    Options

@zaneselvans zaneselvans added docs Documentation for users and contributors. gridlab Work related to open modeling input data integration funded/coordinated by GridLab eiaaeo EIA Annual Energy Outlook labels May 8, 2024
@zaneselvans zaneselvans requested a review from jdangerx May 8, 2024 23:43
@zaneselvans zaneselvans self-assigned this May 8, 2024
@@ -12,7 +12,6 @@
AssetsDefinition,
AssetSelection,
Definitions,
ExperimentalWarning,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random import that was no longer being used. Not sure why Ruff didn't zap it before.

@@ -37,15 +37,15 @@
},
"core_eiaaeo__yearly_projected_generation_in_end_use_sectors_by_fuel_type": {
"description": (
"Projected generation capacity & total generation in the end-use "
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ampersand was getting escaped in the docs to be &

Comment on lines -47 to +48
"Renewable Sources in gigawatts direct current; other technologies "
"in gigawatts alternating current."
"Renewable Sources in megawatts direct current; other technologies "
"in megawatts alternating current."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the transformations these are in megawatts not gigawatts (to be consistent with all of our other data)

@zaneselvans zaneselvans enabled auto-merge May 9, 2024 01:02
Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zaneselvans zaneselvans added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit b2754d3 May 9, 2024
12 checks passed
@zaneselvans zaneselvans deleted the eiaaeo-table-docstrings branch May 9, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation for users and contributors. eiaaeo EIA Annual Energy Outlook gridlab Work related to open modeling input data integration funded/coordinated by GridLab
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants