Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new file for EIA 191 transformations #3631

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

denimalpaca
Copy link

Overview

Closes #2603

What problem does this address?
Adds a core table for EIA 191 given the transforms specified in #2603. Adds enums for specified fields as well as a primary key.

What did you change?
Added EIA 191 files.

Testing

How did you make sure this worked? How can a reviewer verify this?
TBD

To-do list

Edit tasklist title
Beta Give feedback Tasklist To-do list, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. If updating analyses or data processing functions: make sure to update or write data validation tests (e.g., test_minmax_rows())
    Options
  2. Update the release notes: reference the PR and related issues.
    Options
  3. Ensure docs build, unit & integration tests, and test coverage pass locally with make pytest-coverage (otherwise the merge queue may reject your PR)
    Options
  4. Review the PR yourself and call out any questions or issues you have
    Options
  5. For minor ETL changes or data additions, once make pytest-coverage passes, make sure you have a fresh full PUDL DB downloaded locally, materialize new/changed assets and all their downstream assets and run relevant data validation tests using pytest and --live-dbs.
    Options
  6. For significant ETL, data coverage or analysis changes, once make pytest-coverage passes, ensure the full ETL runs locally and run data validation tests using make pytest-validate (a ~10 hour run). If you can't run this locally, run the build-deploy-pudl GitHub Action (or ask someone with permissions to). Then, check the logs on the #pudl-deployments Slack channel or gs://builds.catalyst.coop.
    Options
Loading

denimalpaca and others added 2 commits May 9, 2024 14:31
Created a new file to house EIA 191 transformations. Also added
two Enum classes for field type and status columns, although these
may have to be moved. Current transformations add relevant columns.
Tests will come in a subsequent PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Integrate EIA 176, 191 and 757A into PUDL
1 participant