Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output methods for all remaining EIA 861 tables. #862

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

zaneselvans
Copy link
Member

In working through the tutorial notebooks, I realized we never added these methods for the interim EIA 861 tables, so I went ahead and did it. Would still love to make these kinds of accessors much more automatic with some kind of factory method or something, if you have any suggestions on the right way to do that @rousik.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #862 (7770b21) into sprint29 (1336376) will decrease coverage by 0.23%.
The diff coverage is 38.10%.

Impacted file tree graph

@@             Coverage Diff              @@
##           sprint29     #862      +/-   ##
============================================
- Coverage     71.71%   71.48%   -0.23%     
============================================
  Files            43       43              
  Lines          5072     5102      +30     
============================================
+ Hits           3637     3647      +10     
- Misses         1435     1455      +20     
Impacted Files Coverage Δ
src/pudl/output/pudltabl.py 58.63% <38.10%> (-3.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1336376...46237f2. Read the comment docs.

@zaneselvans zaneselvans merged commit 2c4dcb1 into sprint29 Dec 16, 2020
@zaneselvans zaneselvans deleted the eia861-outputs branch June 1, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant