Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up PyTest config, coverage generation, unit tests #896

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

zaneselvans
Copy link
Member

  • Moved all unit tests into a hierarchy under tests/unit
  • Removed extraneous pytest options in tox.ini being set in pytest.ini
  • The unit and etl testenvs in tox.ini now both append to the coverager
    report.
  • The CI testenv now runs coverage erase to start with a fresh slate
  • Removed unused @pytest.mark.datapkg decorators / cli option
  • PyTest will now show warnings (of which there are a few)

Closes #893

* Moved all unit tests into a hierarchy under tests/unit
* Removed extraneous pytest options in tox.ini being set in pytest.ini
* The `unit` and `etl` testenvs in tox.ini now both append to the coverager
  report.
* The CI testenv now runs `coverage erase` to start with a fresh slate
* Removed unused @pytest.mark.datapkg decorators / cli option
* PyTest will now show warnings (of which there are a few)

Closes #893
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #896 (0d8f010) into sprint29 (2061995) will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           sprint29     #896      +/-   ##
============================================
+ Coverage     77.38%   77.94%   +0.56%     
============================================
  Files            44       44              
  Lines          5721     5721              
============================================
+ Hits           4427     4459      +32     
+ Misses         1294     1262      -32     
Impacted Files Coverage Δ
src/pudl/workspace/datastore.py 71.03% <0.00%> (+1.40%) ⬆️
src/pudl/analysis/timeseries_cleaning.py 88.33% <0.00%> (+2.64%) ⬆️
src/pudl/extract/excel.py 97.22% <0.00%> (+2.78%) ⬆️
src/pudl/workspace/resource_cache.py 84.11% <0.00%> (+13.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2061995...56f1d7b. Read the comment docs.

@zaneselvans zaneselvans merged commit de943a3 into sprint29 Jan 22, 2021
@zaneselvans zaneselvans deleted the tox-unit-tests-3 branch January 22, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant