pudl_datastore --list-partitions #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add support for skipping optimally-cached resources when downloading resources to zenodo cache.
and also update the code to fix some syntax errors.
Break down the various modes of operation into three separate functions.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This fixes #915 |
Codecov Report
@@ Coverage Diff @@
## sprint30 #925 +/- ##
============================================
- Coverage 77.87% 77.78% -0.09%
============================================
Files 45 45
Lines 5824 5859 +35
============================================
+ Hits 4535 4557 +22
- Misses 1289 1302 +13
Continue to review full report at Codecov.
|
zaneselvans
approved these changes
Feb 23, 2021
|
Will definitely improve usability, and efficiency too it looks like. Should we try and get some unit tests for this functionality too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add capability to list available partition keys and known values.