-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements simplification #1002
Conversation
Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-11-20 06:38:50 UTC |
criterion: nn.Module = None, | ||
optimizer=None, | ||
scheduler=None, | ||
**kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
DAR401 Missing exception(s) in Raises section: -r NotImplementedError
41f4d0e
to
7747150
Compare
catalyst/contrib/__main__.py
Outdated
|
||
try: | ||
import sklearn # noqa: F401 | ||
import pandas # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'pandas' from line 86
catalyst/contrib/__main__.py
Outdated
|
||
try: | ||
import nmslib # noqa: F401 | ||
import sklearn # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'sklearn' from line 100
catalyst/contrib/__main__.py
Outdated
|
||
try: | ||
import nmslib # noqa: F401 | ||
import sklearn # noqa: F401 | ||
import pandas # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'pandas' from line 101
catalyst/contrib/__main__.py
Outdated
import cv2 # noqa: F401 | ||
import imageio # noqa: F401 | ||
import torchvision # noqa: F401 | ||
import pandas # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'pandas' from line 128
catalyst/contrib/__main__.py
Outdated
) | ||
raise ex | ||
|
||
try: | ||
import transformers # noqa: F401 | ||
import pandas # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'pandas' from line 149
This pull request is now in conflicts. @Scitator, could you fix it? 🙏 |
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?pytest .
?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
PS