Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements simplification #1002

Merged
merged 54 commits into from Nov 26, 2020
Merged

Requirements simplification #1002

merged 54 commits into from Nov 26, 2020

Conversation

Scitator
Copy link
Member

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

PS

  • I know, that I could join slack for pull request discussion.

@pep8speaks
Copy link

pep8speaks commented Nov 17, 2020

Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 13:80: E501 line too long (80 > 79 characters)

Line 15:1: E402 module level import not at top of file
Line 81:1: E402 module level import not at top of file
Line 82:1: E402 module level import not at top of file

Line 42:1: E402 module level import not at top of file

Comment last updated at 2020-11-20 06:38:50 UTC

criterion: nn.Module = None,
optimizer=None,
scheduler=None,
**kwargs,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
DAR401 Missing exception(s) in Raises section: -r NotImplementedError

@Scitator Scitator force-pushed the arch/requirements-simplification branch from 41f4d0e to 7747150 Compare November 24, 2020 06:42

try:
import sklearn # noqa: F401
import pandas # noqa: F401

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'pandas' from line 86


try:
import nmslib # noqa: F401
import sklearn # noqa: F401

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'sklearn' from line 100


try:
import nmslib # noqa: F401
import sklearn # noqa: F401
import pandas # noqa: F401

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'pandas' from line 101

import cv2 # noqa: F401
import imageio # noqa: F401
import torchvision # noqa: F401
import pandas # noqa: F401

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'pandas' from line 128

)
raise ex

try:
import transformers # noqa: F401
import pandas # noqa: F401

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
F811 redefinition of unused 'pandas' from line 149

@mergify
Copy link

mergify bot commented Nov 25, 2020

This pull request is now in conflicts. @Scitator, could you fix it? 🙏

@Scitator Scitator mentioned this pull request Nov 26, 2020
1 task
@Scitator Scitator merged commit 0a2afda into master Nov 26, 2020
@mergify mergify bot deleted the arch/requirements-simplification branch November 26, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants