Apex with DataParallel fixes #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scitator
reviewed
Dec 14, 2020
Comment on lines
+64
to
+65
| if isinstance(model, nn.Module): | ||
| model = nn.Sequential(model) |
There was a problem hiding this comment.
why are we checking the model for nn.Module, but cast it to nn.Sequential after that?
Comment on lines
+69
to
+70
| model = torch.nn.DataParallel(model[0]) | ||
| model = _patch_forward(model) |
There was a problem hiding this comment.
okay, that looks like really tricky solution
catalyst/utils/components.py
Outdated
| else tensor | ||
| ) | ||
|
|
||
| model.forward = lambda *args, old_fwd=model.forward, input_caster=input_caster_lambda, output_caster=output_caster_lambda, **kwargs: apex.amp._initialize.applier( |
There was a problem hiding this comment.
is it possible to use **kwargs with this hack?
|
Changelog is updated, codestyle is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?pytest .?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.