Utils callbacks #1127

elephantmipt · 2021-03-21T12:54:55Z

Before submitting (checklist)

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contribution guide?
Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
Did you make sure to update the docs? We use Google format for all the methods and classes.
Did you check the docs with make check-docs?
Did you write any new necessary tests?
Did you check that your code passes the unit tests pytest . ?
Did you add your new functionality to the docs?
Did you update the CHANGELOG?

Description

Related Issue

Type of Change

Examples / docs / tutorials / contributors update
Bug fix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves an existing feature)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

PS

I know, that I could join slack for pull request discussion.

catalyst/callbacks/quantization.py

catalyst/utils/best_model.py

catalyst/callbacks/quantization.py

…backs

pep8speaks · 2021-03-21T20:38:49Z

Hello @elephantmipt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-28 09:13:44 UTC

catalyst/callbacks/quantization.py

catalyst/callbacks/onnx.py

github-actions · 2021-03-21T21:21:40Z

catalyst/callbacks/tracing.py

+from catalyst.utils import trace_model
+
+
+class TracingCallback(Callback):


[pep8] _{reported by reviewdog 🐶}
D101 Missing docstring in public class

github-actions · 2021-03-21T21:21:40Z

catalyst/callbacks/tracing.py

+        self.method_name = method_name
+        self.batch = batch
+
+    def on_stage_end(self, runner: "IRunner") -> None:


[pep8] _{reported by reviewdog 🐶}
D102 Missing docstring in public method

github-actions · 2021-03-21T21:21:40Z

catalyst/callbacks/tracing.py

+        self.method_name = method_name
+        self.batch = batch
+
+    def on_stage_end(self, runner: "IRunner") -> None:


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'IRunner'

github-actions · 2021-03-22T17:56:05Z

catalyst/callbacks/quantization.py

+        qconfig_spec: Dict = None,
+        dtype: Union[str, Optional[torch.dtype]] = "qint8",
+
+    ):


[pep8] _{reported by reviewdog 🐶}
WPS355 Found an unnecessary blank line before a bracket

catalyst/callbacks/quantization.py

catalyst/callbacks/onnx.py

github-actions · 2021-03-22T17:56:06Z

catalyst/utils/quantization.py

@@ -12,7 +12,8 @@ def quantize_model(
    """Function to quantize model weights.

    Args:
-        model (Model): model to quantize
+        logdir: path to folder for saving


[pep8] _{reported by reviewdog 🐶}
DAR102 Excess parameter(s) in Docstring: + filename

catalyst/callbacks/__init__.py

catalyst/callbacks/onnx.py

catalyst/callbacks/quantization.py

catalyst/callbacks/tracing.py

…backs

Scitator · 2021-03-27T05:46:46Z

@elephantmipt could you please add these callbacks to one of the minimal examples test?
https://github.com/catalyst-team/catalyst/tree/master/catalyst/tests
So we could check them in a CI way ;)

catalyst/callbacks/__init__.py

* verbose * Utils callbacks (#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <37884009+elephantmipt@users.noreply.github.com>

* verbose * Utils callbacks (catalyst-team#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (catalyst-team#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <37884009+elephantmipt@users.noreply.github.com>

* add movielens * First hitrate metric version * metrge with upstream * fix topk_map * fix error in map * tests for map * top_k ndcg * edit changelog * edit the tabs * check codestyle * check the intent * check the intent * remove trailing whitespace * fixed hitrate * fixed the docs * hitrate * Additive margin softmax (#1131) * Added Additive-margin softmax * update changelog.md * Readme update2 (#1142) * readme * batch overfit fix for reproducibility * batch overfit fix for reproducibility * readme * readme update * extra Config/Hydra API fixes * codestyle * updated dl_cpu(workflows)- For passing CI-Tests (#1135) * updated dl_cpu * Updated-requirements-ml.txt * corrected the mistake * Update dl_cpu.yml * Update requirements-ml.txt * Kept dl_cpu 20.04-3.6 minimal as requested * Corrected the mistakes * Add requirements parameter * Update dl_cpu.yml * Update dl_cpu.yml Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * fix: `_key_value` for schedulers in case of multiple optimizers fixed (#1146) * Github CI fixes (#1143) * verbose * Utils callbacks (#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <37884009+elephantmipt@users.noreply.github.com> * Engine docs (#1141) * typings & few docs * typing fix; disabled `dist.barrier()` in optimizer step for ddp * docs * docs: fixed long lines with docs * docs fixes * optimizer args * removed empty line Co-authored-by: Dmytro Doroshenko <dimdoroshenko@gmail.com> * v21.03.1 * v21.03: minimal version fix (#1147) * minimal version fix * docs * fix: nested dicts in loaders_params/samplers_params overriding (#1150) * docs (#1152) * Github CI fix (#1148) * fix * fix * Niftireader (#1151) * changes for NiftiReader * adding import statement that was needed and fixing codestyle * updated CHANGELOG * removing unnecesary documentation * fixing codestyle * updated docs and requirements * adding a space * not importing nibabel for docs * fixing typo * adding step for contrib pip caching * fixed codestyle and added a test for reader that uncovered a mistake :) * hopefully fixing imports * adding sergey suggested fix * fixing deploy_push.yml * updating workflows Co-authored-by: Kevin Wang <kevin.wang@affectiva.com> Co-authored-by: Kevin Wang <kcwang26@gsu.edu> * add changelog * solved runtime error * hitrate calculation Co-authored-by: Daniel Chepenko <dchepenk@yahoo-corp.co> Co-authored-by: denyhoof <kde97@yandex.ru> Co-authored-by: Даниил <zkid18@MacBook-Pro.Dlink> Co-authored-by: Atharva Phatak <athp456@gmail.com> Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> Co-authored-by: Yauheni Kachan <19803638+bagxi@users.noreply.github.com> Co-authored-by: Nikita Balagansky <37884009+elephantmipt@users.noreply.github.com> Co-authored-by: Dmytro Doroshenko <dimdoroshenko@gmail.com> Co-authored-by: Kevin Wang <kcwang@ymail.com> Co-authored-by: Kevin Wang <kevin.wang@affectiva.com> Co-authored-by: Kevin Wang <kcwang26@gsu.edu>

* verbose * Utils callbacks (catalyst-team#1127) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * tests * tests * tests * tests * tests * pycharm tricks * extra tests * Utils callbacks (catalyst-team#1145) * quantization.py * onnx and quantization * tracing.py * docs * fix * fix * quantization test * fix test * fix comments * fix comments * quantization example * examples * CHANGELOG.md * fix * fix * Apply suggestions from code review Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 * extra tests 2 Co-authored-by: Nikita Balagansky <37884009+elephantmipt@users.noreply.github.com>

elephantmipt and others added 2 commits March 21, 2021 15:53

quantization.py

8b9a877

Merge branch 'master' into utils_callbacks

5da6014

github-actions bot reviewed Mar 21, 2021

View reviewed changes

Scitator reviewed Mar 21, 2021

View reviewed changes

catalyst/utils/best_model.py Outdated Show resolved Hide resolved

catalyst/callbacks/quantization.py Outdated Show resolved Hide resolved

catalyst/callbacks/quantization.py Outdated Show resolved Hide resolved

elephantmipt added 2 commits March 21, 2021 23:38

onnx and quantization

346092b

Merge remote-tracking branch 'origin/utils_callbacks' into utils_call…

223f02f

…backs

github-actions bot reviewed Mar 21, 2021

View reviewed changes

catalyst/callbacks/quantization.py Outdated Show resolved Hide resolved

catalyst/callbacks/onnx.py Show resolved Hide resolved

catalyst/callbacks/onnx.py Show resolved Hide resolved

catalyst/callbacks/onnx.py Outdated Show resolved Hide resolved

tracing.py

0960d02

github-actions bot reviewed Mar 21, 2021

View reviewed changes

elephantmipt added 2 commits March 22, 2021 20:49

docs

677362d

fix

68637cb

github-actions bot reviewed Mar 22, 2021

View reviewed changes

elephantmipt and others added 2 commits March 22, 2021 21:07

fix

49ed408

Merge branch 'master' into utils_callbacks

31f0e5f

Scitator reviewed Mar 23, 2021

View reviewed changes

elephantmipt and others added 7 commits March 26, 2021 23:59

quantization test

b00287b

Merge remote-tracking branch 'origin/utils_callbacks' into utils_call…

e1228e1

…backs

Merge branch 'master' into utils_callbacks

fe88234

fix test

8642b58

Merge remote-tracking branch 'origin/utils_callbacks' into utils_call…

c9cb37c

…backs

fix comments

18b2396

fix comments

6619698

Scitator marked this pull request as ready for review March 28, 2021 05:43

Scitator requested review from bagxi and ditwoo as code owners March 28, 2021 05:43

Merge branch 'master' into utils_callbacks

9c54165

Scitator reviewed Mar 28, 2021

View reviewed changes

catalyst/callbacks/__init__.py Outdated Show resolved Hide resolved

Update catalyst/callbacks/__init__.py

eeb1f0f

Scitator changed the base branch from master to github-ci-fix March 28, 2021 09:14

Scitator merged commit 548de49 into github-ci-fix Mar 28, 2021

mergify bot deleted the utils_callbacks branch March 28, 2021 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Utils callbacks #1127

Utils callbacks #1127

elephantmipt commented Mar 21, 2021

pep8speaks commented Mar 21, 2021 •

edited

github-actions bot Mar 21, 2021

github-actions bot Mar 21, 2021

github-actions bot Mar 21, 2021

github-actions bot Mar 22, 2021

github-actions bot Mar 22, 2021

Scitator commented Mar 27, 2021

		from catalyst.utils import trace_model


		class TracingCallback(Callback):

Utils callbacks #1127

Utils callbacks #1127

Conversation

elephantmipt commented Mar 21, 2021

Before submitting (checklist)

Description

Related Issue

Type of Change

PR review

pep8speaks commented Mar 21, 2021 • edited

Comment last updated at 2021-03-28 09:13:44 UTC

github-actions bot Mar 21, 2021

Choose a reason for hiding this comment

github-actions bot Mar 21, 2021

Choose a reason for hiding this comment

github-actions bot Mar 21, 2021

Choose a reason for hiding this comment

github-actions bot Mar 22, 2021

Choose a reason for hiding this comment

github-actions bot Mar 22, 2021

Choose a reason for hiding this comment

Scitator commented Mar 27, 2021

pep8speaks commented Mar 21, 2021 •

edited