Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler callback #1226

Merged
merged 25 commits into from Jun 27, 2021
Merged

Profiler callback #1226

merged 25 commits into from Jun 27, 2021

Conversation

ditwoo
Copy link
Contributor

@ditwoo ditwoo commented May 31, 2021

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • Did you run colab minimal CI/CD with latest and minimal requirements?

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

FAQ

Please review the FAQ before submitting an issue:

@ditwoo ditwoo changed the title feature: profiler callback initial Profiler callback May 31, 2021
catalyst/callbacks/profiler.py Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Show resolved Hide resolved
catalyst/callbacks/profiler.py Show resolved Hide resolved
@ditwoo ditwoo changed the title Profiler callback [WIP] Profiler callback May 31, 2021
@pep8speaks
Copy link

pep8speaks commented Jun 15, 2021

Hello @ditwoo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-25 17:06:49 UTC

catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
catalyst/callbacks/profiler.py Outdated Show resolved Hide resolved
Comment on lines 175 to 178
for logger in loggers_:
logger.log_artifact(
tag="profiler", artifact="profiler.txt", path_to_artifact=artifact_path,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, let's use runner.log_artifact instead?

Copy link
Contributor Author

@ditwoo ditwoo Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll change that.
Btw, will it work correctly when dictionary with loggers is empty?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup :)

@mergify
Copy link

mergify bot commented Jun 25, 2021

This pull request is now in conflicts. @ditwoo, could you fix it? 🙏

@ditwoo ditwoo changed the title [WIP] Profiler callback Profiler callback Jun 25, 2021
@Scitator Scitator merged commit 7b4bd10 into master Jun 27, 2021
@mergify mergify bot deleted the profiler-callback branch June 27, 2021 07:45
@Scitator Scitator mentioned this pull request Jun 28, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants