Fixed docstring PeriodicLoaderCallback #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nimrais
changed the title
Nimrais
added a commit
to Nimrais/catalyst
that referenced
this pull request
Aug 19, 2021
Scitator
added a commit
that referenced
this pull request
Aug 19, 2021
* Contrastive learning example - Barlow Twins * add ed__name__ == __main__ * added name == main * zeros for is_query * contrastive learning - feature accumulator * purguing unused * feature accumulator from ICallbackLoaderMetric * fixed typo * feature bank from AccumulationMetric * add valid loader +KNNClassiferCallback * class SklearnClassifierCallback(ICallback): * delete commented * Update examples/catalyst_contrastive/callbacks.py laconic way of the rest call in SklearnClassifierCallback Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * *args and **kwargs only via partial call * deleted unused * Fixed typos * add __init__.py * Fixed typo * appropriate lambda selection * added logdir into runner * more epochs :) * full dataset * assert earlier * SklearnClassifierCallback is moved to catalyst/callbacks * changed file name * add 2 lines before __all__ * name changed * Update sklearn_classifier.py * Update sklearn_classifier.py * autosave bugs * added docs * fixed typo * sklearn classifier callbacj integration test * SklearnClassifierCallback integretion test * added argparse * add mark from pytest * fixed typo * fixed typo * top_k -> logloss * deleted top_k * used ResnetEncoder instead of manual resnet init * ICallback -> Callback * Functional API -> nn.Flatten * unused imports * runner logic * test runner sklearn logic * Fixed typo * less epochs for integration test * renamed SklearnClassifierCallback -> SklearnModelCallback * sklearn_classifier.py -> sklearn_model.py * Added SklearnModelCallback into docs/api/callbacks.rst * bad indent for the docs * catalyst[ml] note * Fixed the problems with docs/api/callbacks.rst * Fixed outdated docs * Fixed docs * Fixed typo * addded assert for the quality check * cleaned dependencies in the Examples section * predict_proba + cleaned dependencies in examples/catalyst_contrastive/barlow_twins * Update examples/catalyst_contrastive/barlow_twins.py Cuda isn't needed for example purposes. Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * added classifier kwargs * updated CHANGELOG.md * add classifier kwargs * download=True because of CI * supprt of Config API * support of Config API * TSNE hasn't predict * add engine and device into integrated test * big numbers at the start of the training in the integration test * add hypeparametrs in the integration test * fixed typo * clip the Tensors for the test * Update tests/pipelines/test_sklearn_classifier.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * Update catalyst/callbacks/__init__.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * Fixed typo * sklearn_predicts are only in the infer loader * additional params inside RandomForest * add requriment in the callback test * add example with str for SklearnModelCallback * appropriate fix seed * more estimators * batch norm model * mnist metric learning full * _split = 5 * add split param in MnistMLDataset * Update tests/pipelines/test_sklearn_classifier.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * reverted datasets/mnist.py * reverted to e43c62e * integration test only on MNIST dataset * LogisticRegression in the integration test * Update catalyst/callbacks/sklearn_model.py Co-authored-by: Sergey Kolesnikov <scitator@gmail.com> * too long line * safe detach sklearn_model.py * pdb * pdb in right place * commented pdb * big guns in the integration test * unused param in MnistBatchNormNet * compare only best accuracy * batch norm network * MnistSimpleNet in the integrated test * activate pdb * commented pdb * TRAIN_EPOCH = 4 is enough for the test * refactored params in SklearnModelCallback * support .fit without traget * safe embeddings * fill the inf * MNIST -> make blobs :) * dirty trick np.nan_to_num inside code * fixed typo * make blobs -> make classification * fixed bug in SklearnModelCallback * fixed typo * clear the class SklearnModelCallback(Callback): * faster network * SklearnModelCallback more then one valid loader * updated docsting SklearnModelCallback * Check Loader Loader * fixed docsting PeriodicLoaderCallback (#1279) Co-authored-by: Mykola Lukashchuk <Mykola Lukashchuk> Co-authored-by: Sergey Kolesnikov <scitator@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (checklist)
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?pytest .?latestandminimalrequirements?Description
PeriodicLoaderRunnerCallbackis used in thePeriodicLoaderCallbackdocstring.This PR fixed this.
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
FAQ
Please review the FAQ before submitting an issue: