Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for self-supervised examples #1322

Merged
merged 25 commits into from
Oct 8, 2021

Conversation

Nimrais
Copy link
Contributor

@Nimrais Nimrais commented Oct 5, 2021

Pull Request FAQ

Description

We have a lot of self-supervised algorithms to test.
The Docker is the selected option for the testing.

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest and minimal requirements?
  • Have you checked XLA integration with single and multiple processes?

@pep8speaks
Copy link

pep8speaks commented Oct 6, 2021

Hello @Nimrais! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-08 03:19:55 UTC

@@ -74,3 +82,52 @@ def forward(self, x):
emb = self.encoder(x)
projection = self.model(emb)
return emb, projection


def get_loaders(args) -> Dict[str, DataLoader]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's unpack args here (very bad practice, hard to understand)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dataset, batch_size, num_workers, etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return {"train": train_loader, "valid": valid_loader}


def get_contrastive_model(args) -> ContrastiveModel:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/self_supervised/Dockerfile Show resolved Hide resolved
@mergify mergify bot dismissed Scitator’s stale review October 8, 2021 03:20

Pull request has been modified.

@Scitator Scitator merged commit d81db52 into catalyst-team:master Oct 8, 2021
@Nimrais Nimrais deleted the docker-for-self-supervised branch December 1, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants