-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile for self-supervised examples #1322
Dockerfile for self-supervised examples #1322
Conversation
…yst into docker-for-self-supervised
examples/self_supervised/common.py
Outdated
@@ -74,3 +82,52 @@ def forward(self, x): | |||
emb = self.encoder(x) | |||
projection = self.model(emb) | |||
return emb, projection | |||
|
|||
|
|||
def get_loaders(args) -> Dict[str, DataLoader]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's unpack args here (very bad practice, hard to understand)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataset, batch_size, num_workers, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples/self_supervised/common.py
Outdated
return {"train": train_loader, "valid": valid_loader} | ||
|
||
|
||
def get_contrastive_model(args) -> ContrastiveModel: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request FAQ
Description
We have a lot of self-supervised algorithms to test.
The Docker is the selected option for the testing.
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Checklist
latest
andminimal
requirements?