Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ABC from collections.abc for Python 3.10 compatibility #1409

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Import ABC from collections.abc for Python 3.10 compatibility #1409

merged 3 commits into from
Apr 11, 2022

Conversation

tirkarthi
Copy link
Contributor

Description

Import ABC from collections.abc for Python 3.10 compatibility since importing from collections directly was deprecated and removed in Python 3.10

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest requirements? Please attach the notebook link.
  • Have you run colab minimal CI/CD with minimal requirements? Please attach the notebook link.
  • Have you checked XLA integration? Please attach the notebook link.
  • Have you checked distributed XLA integration? Please attach the notebook link.

@ShuhuaGao
Copy link

Why is this PR not merged? The current version 22.02.1 does not work in Python 3.10 due to the above issue. In fact, collections.abc appears in Python 3.3 (https://docs.python.org/3/library/collections.abc.html)

@Scitator
Copy link
Member

@ShuhuaGao we are waiting for the tests to launch, but it looks like we caught github issue here
@tirkarthi it would be great if you could resubmit your PR, thanks!

PS. sorry, I have a long ping nowadays - too many conferences.

@tirkarthi tirkarthi closed this Apr 11, 2022
@tirkarthi tirkarthi reopened this Apr 11, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2022

CLA assistant check
All committers have signed the CLA.

@tirkarthi
Copy link
Contributor Author

I have closed and reopened the PR. It should trigger tests.

@Scitator
Copy link
Member

looks like we have a bunch of requirements related issues 😢
I will merge this PR, but it would be great if someone will PR the requirements fix. thanks in advance!

@Scitator Scitator merged commit bd9578e into catalyst-team:master Apr 11, 2022
@tirkarthi
Copy link
Contributor Author

Thanks @Scitator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants