-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extra checkpoint data #184
Conversation
catalyst/dl/callbacks/base.py
Outdated
@@ -102,6 +102,9 @@ def on_epoch_end(self, state: RunnerState): | |||
if state.stage.startswith("infer"): | |||
return | |||
|
|||
extra_checkpoint_data = state.extra_checkpoint_data \ | |||
if hasattr(state, 'extra_checkpoint_data') else {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just add checkpoint_data
to state init, so we can use it also from Config API.
proposed way:
state_params:
checkpoint_data:
exp: "thin is my best experiments"
date: "today"
This will also reduce such hasattr
check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's squash all small commits into one or two. Keep our history simple and clean!
Allows to save additional metadata to checkpoint files: